Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(spanner): bump to 1.5.22 #595

Merged
merged 1 commit into from
Oct 4, 2024
Merged

feat(spanner): bump to 1.5.22 #595

merged 1 commit into from
Oct 4, 2024

Conversation

fredrikaverpil
Copy link
Member

I'm not bumping all the way to 1.5.24 as we are seeing issues with Spanner on
macOS on versions released after 1.5.22.

I've added a note on this limitation/issue in our internal macOS tech-radar.

We should investigate and perhaps file an issue with
https://github.com/GoogleCloudPlatform/cloud-spanner-emulator

@fredrikaverpil fredrikaverpil requested a review from a team as a code owner October 4, 2024 09:05
@fredrikaverpil fredrikaverpil self-assigned this Oct 4, 2024
@fredrikaverpil fredrikaverpil requested a review from radhus October 4, 2024 09:05
@odsod
Copy link
Member

odsod commented Oct 4, 2024

@fredrikaverpil filing issue sounds great, please do if you have time! 🙏

@fredrikaverpil fredrikaverpil merged commit a9ff6bb into master Oct 4, 2024
3 checks passed
@fredrikaverpil fredrikaverpil deleted the spanner branch October 4, 2024 09:52
@fredrikaverpil
Copy link
Member Author

@odsod FYI it was not them, it was us 😄 (as expected)
@radhus found the problem, which is that we pass pointers into transactions (which get mutated by e.g. our internal spanner timestamp marker). Spanner is free to retry the transaction - and this got a lot more frequent in spanner emulator 1.5.23 (which is a good thing).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants